Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construction/Deconstruction issues with air alarms #3087

Closed
Jamini opened this issue Jun 17, 2013 · 5 comments
Closed

Construction/Deconstruction issues with air alarms #3087

Jamini opened this issue Jun 17, 2013 · 5 comments

Comments

@Jamini
Copy link
Contributor

Jamini commented Jun 17, 2013

Air alarm construction is currently bugged.

  1. Constructing an air alarm currently only requires building a frame and placing it on a wall. It should involve a wiring and circuit installation step.
    How to reproduce: build an air alarm frame, place it on a wall.
  2. Constructed air alarms do not respect walls/facing. Instead they spawn at dir 1 with no changes to pixel_x/y.
    How to reproduce: build an air alarm.
  3. It is impossible to deconstruct an air alarm currently. The deconstruction process should be:
    A. Unlock alarm (optional)
    B.Unscrew alarm
    C. Cut siphon wire (optional)
    D. Turn off siphon(optional)
    E. Cut all remaining wires
    F. Wirecutters on the air alarm
    G. Crowbar out the electronics
    H. Wrench to remove from wall
    I. Welder to deconstuct the frame icon to metal..

How to reproduce: attempt to follow those steps. The process will fail at step E.

@ghost
Copy link

ghost commented Jun 17, 2013

No idea how this stuff works. I'll let someone else fix this issue.

@MistakeNot4892
Copy link
Contributor

I'll take a look at it in the next few days.

@Ispil
Copy link
Contributor

Ispil commented Jul 4, 2013

Well, it would appear that the main issue with this is that the code for air alarms is incomplete. In the case of your second issue, that's not a bug. The person who made atmos alarms never cared to put in that functionality- they just copied the APC_Frame code, changed one or two things, and called it Alarm_Frame. No pixel-pushing at all.

@MistakeNot4892
Copy link
Contributor

I think this one might be beyond me. I've added construction/deconstruction, but deconstructing an air alarm utterly destroys Dream Daemon with runtimes. I don't know enough about atmos to safely delete one.

@MistakeNot4892
Copy link
Contributor

Resolved the construction runtimes, but deconstruction isn't in because I don't know how to fix it and honest to god the air alarm code terrifies me.

@comma comma closed this as completed in 81e22ea Jul 10, 2013
bloxgate pushed a commit to bloxgate/BloxStation that referenced this issue Jan 29, 2022
bloxgate pushed a commit to bloxgate/BloxStation that referenced this issue Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants