Capacity-based storage system #10095

RavingManiac · 2015-07-10T11:34:11Z

Storage system for backpacks, boxes, etc. altered to be storage-capacity based. Items take up space based on w_class by default, with custom storage costs also possible. Space in container represented as a bar, with each stored item positioned along the bar with an overlay representing how much space they are taking up.

Backpacks have a capacity of 16, boxes have a capacity of 8 and toolboxes have a capacity of 14. A backpack can store 2 spacesuits, 4 fire extinguishers, 8 emergency oxygen tanks or 16 pens.

Belts, excavation kits and some other containers still use the slot system.

Current screenshots (5 January 2016):

Backpack with various items
Backpack with spacesuit
Box
Toolbox

GinjaNinja32 · 2015-07-10T11:35:32Z

code/game/objects/items/weapons/storage/storage.dm


+	//src.boxes.screen_loc = "4:16,2:16 to [4+cols]:16,[2+rows]:16"
+	var/icon/I = new(src.storage_box_continue.icon)
+	I.Scale(storage_box_length-4,32)


ew icon procs :(

mwerezak · 2015-07-10T11:39:48Z

Please do not generate and manipulate new icons every time the inventory is displayed.

GinjaNinja32 · 2015-07-10T11:51:27Z

As mwerezak said, don't do /icon stuff every time it's displayed. If you really have to use /icon, cache it, otherwise use /image.

Dennok · 2015-07-10T12:04:41Z

Yes! I know it! Someone make system what i offered.
Really nice window for items.

RemieRichards · 2015-07-10T13:07:35Z

Use /image and some matrix maths.

Scale() example:

var/image/I = image(file,state)
var/matrix/M = Matrix()
M.Scale(X_axis,Y_axis)
I.transform = M

and Shift() would be a Matrix Translate() etc.

mwerezak · 2015-07-10T14:38:20Z

You may want to reduce storage capacities across the board with this, as it represents an overall buff to the amount of things that people can easily store (which itself has been creeping up with widespread webbings and security now having pockets in their armour vests).

Making backpacks able to carry 3 or 4 large items (instead of 7) seems like a reasonable place to start IMO.

RavingManiac · 2015-07-10T14:48:06Z

code/game/objects/items/weapons/storage/storage.dm

+			underlay_end.Shift(EAST,endpoint-object_offset-2)
+			O.underlays += underlay_start
+			O.underlays += underlay_continue
+			O.underlays += underlay_end


In theory, this should give items an underlay in the storage menu. Nothing is showing up, though. Any idea what might be the problem?

I would hazard a guess that it is because underlay_start, end, and continue are icons, not images.

@mwerezak as far as I'm aware the overlays and underlays lists can contain the following:

Images

Icons

Appearences (overlays += "state" adds an Appearence not an icon or image)

Objects (Byond will deal with it)

scrdest · 2015-07-10T19:50:11Z

I wonder, does this support items with separate 'pockets'? Because the dual slots for storage in most storage-type coats seem to represent two pockets, and purely volumetric storage means instead of a cigarette packet and a lighter, you may elect to store a twice as large cane (I don't know actual sizes, but you get the idea), presumably with each end in a separate pocket and the middle just kinda hanging there.

RavingManiac · 2015-07-10T19:52:01Z

Right now, I'm planning for some storage items like belts, excavation kits and coats to still use slot-based storage

mwerezak · 2015-07-10T19:52:14Z

Yes it does. In fact, this is the same system we have currently, with some parameters tweaked and a new UI. So it should support everything the existing system does.

RavingManiac · 2015-07-10T20:01:40Z

Managed to get the bars representing storage cost to work. Mostly a matter of balancing and modifying other systems to fit now

SkowronX · 2015-07-10T20:15:55Z

Icons appear a bit too bunched up and messy, is the interface a work in progress?

Dennok · 2015-07-10T20:45:03Z

@SkowronX No no. I'm sure as intended. If you stick a bunch of things in a backpack will be difficult to pull something one, it presents it.
Dark background shows the amount of occupied thing.

SkowronX · 2015-07-10T20:49:02Z

Then that should be changed. It's not aesthetically great looking.

atlantiscze · 2015-07-10T20:49:40Z

I agree with @SkowronX - While i like the general idea, the visual look of the UI is not good. The items are too close together and overlap the boxes, that should not happen.

Dennok · 2015-07-10T22:03:11Z

@atlantiscze @SkowronX It only one way to show many icons of many obj in one row.

It bade by some VV cheat but show ...

atlantiscze · 2015-07-10T22:26:26Z

I counted about 60 lines in that, each 7 items. That is a total of 420 items. Even with tiny ones, nothing should fit that many items at once. For example a backpack with 7 slots /as it is now/ would store 7 large items (wclass 4), therefore 7*4 tiny items (wclass 1). Four rows. Not sixty. Your argument is not valid in this case.

And of course, we can always have limit to amount of items in one storage if we ever have storages that are so large they would take up whole screen.

EDIT: I also don't think that "ICly backpack full of small stuff would mean it will be hard to pull something out of it" warrants creating UI that is uncomfortable to use. Keep IC things IC, and keep mechanical changes OOCly comfortable to players.

MistakeNot4892 · 2015-07-11T01:39:24Z

I actually really like the way it looks. It's not as parsable as the previous version but that's kind of a good thing, and it does give you an immediate indication of how much space something is taking up.

Fox-McCloud · 2015-07-11T02:15:21Z

@Dennok

And that's why you enable item stacks for storage =V

mwerezak · 2015-07-11T04:47:25Z

@atlantiscze A w_class 4 item takes up eight times the space as a w_class 1 item.

mwerezak · 2015-07-11T04:49:14Z

code/game/objects/items/weapons/storage/toolbox.dm

@@ -10,7 +10,6 @@
 	throw_speed = 1
 	throw_range = 7
 	w_class = 4
-	max_w_class = 3


Why are you removing these?

Having a max_w_class makes sense when storage is slot-based, but with capacity-based storage, it no longer makes sense to arbitrarily limit the size of items that can be put in when this is already balanced by storage capacity.

That's not true at all. For instance, items should not be able to fit in a container the smaller than them. And storing items involves more than pure volumes - things like the shape of the items being stored and the size of openings matter as well.

I'm not sure if you've taken any time to think about this at all. Fire axes, shotguns and similar items should not fit in backpacks and similar containers, both for balance reasons and because otherwise it does not "make sense." Being able to store infinite amounts of backpacks/toolboxes/anything else inside each other hardly "makes sense" either.

Except it's not balanced, because if you have containers with combined w_class more than 4 you can stack them inside each other forever.

Plan is to give storage items a "storage_cost" value one greater than their max_storage_capacity. I'm still tweaking the values to keep things balanced.

That seems like an inelegant solution.

Either you are going to have storage items that are bizarrely humongous compared to every other item in the game, or your storage item capacities are going to become very small.

Also i think it was a nice feature how using boxes to organize the contents of your backpack would yield more storage space. Under your system that would be impossible to implement.

It just seems like pointless cutting away of design space for no good reason. With max_w_class we already achieve the same thing and have more control over how the storage item behaves.

Dennok · 2015-07-11T07:42:33Z

Backpack not is box, it don't hold his volume. Empty backpack can be pasted into another backpack. Tool belt with tools must have more volume when 1 slot and less when empty.
Containers like a box must calculate its volume in another way : w_class = all_what_can_hold + 1
All elastic storages like backpack, belts, itc : w_class = all_what_actually_hold + 1
w_class can be volume modifier and real_volume_of_thing = thing.w_class * constanta
this make items wisch w_class = 5 more bigger when w_class = 1

For security, must completely cut inserting objects in container, that in container.

mwerezak · 2015-07-11T15:40:28Z

@RavingManiac

Having slept on it, I've realized that my biggest objection to this PR as-planned (because as-is it is completely broken) is the fact that it will make organizing the contents of a backpack using boxes provide no benefit whatsoever.

I'm not happy with this feature being axed with little to no justification whatsoever. Especially since the only argument for removing it is on the grounds of "making sense" and I would argue that organizing your backpack using smaller containers to gain extra storage space does in fact make a good deal of sense - In addition to the gameplay aspect that rewarding players for taking a little bit of extra effort gives boxes a purpose and provides players with the choice to use them or not.

As far as I can tell, max_w_class does everything we need and works very well for the purposes that we want of it. Replacing it with a new system, especially deciding that it should go when it's replacement has not even been fully fleshed out yet seems unsettling and... like a waste of effort, honestly.

Still, as long as whatever new system you are playing with allows for players to be rewarded with some extra storage space for organizing their backpacks using boxes, then I guess I'm not one to tell you that you can't do that.

RavingManiac · 2015-11-08T02:35:59Z

Busy at the moment, but I'll get back to this in a few weeks.

…to dev

RavingManiac · 2015-11-19T06:48:29Z

Fixed

MistakeNot4892 · 2015-12-16T13:24:15Z

A decision is needed for this.

headswe · 2015-12-20T19:04:06Z

All the yes!

RavingManiac · 2015-12-22T03:17:47Z

I'm happy to update and balance this as soon as you folks decide that it should go in

headswe · 2016-01-03T21:55:33Z

Another two weeks ;)

PsiOmegaDelta · 2016-01-04T08:55:01Z

Asked how it was working out for Yonagoni/Europa. Quick answer was that while no intensive testing has been done things do seem to work fine with some minor concerns of some sprites being larger than their storage slot.
I am willing to 👍 this, get some more IG testing done, and tweaks can be made based on that.

Techhead0 · 2016-01-04T09:10:41Z

code/game/objects/items/weapons/storage/storage.dm

@@ -12,10 +12,16 @@
 	var/list/can_hold = new/list() //List of objects which this item can store (if set, it can't store anything else)
 	var/list/cant_hold = new/list() //List of objects which this item can't store (in effect only if can_hold isn't set)
 	var/list/is_seeing = new/list() //List of mobs which are currently seeing the contents of this item's storage
-	var/max_w_class = 2 //Max size of objects that this object can store (in effect only if can_hold isn't set)
+	var/max_w_class = null //Max size of objects that this object can store (in effect only if can_hold isn't set)


This change removes size restrictions from a bunch of subtypes that don't have max_w_class set.
Found so far: boxes, bibles, and first aid kits.

…to dev

…um w-class set to 4 and 3 respectively. Storage box sprite made lighter to improve visibility against dark backgrounds.

RavingManiac · 2016-01-06T09:25:17Z

Updated and balanced.

Techhead0 · 2016-01-06T10:12:44Z

As far as I can tell, this means you can fit two backpacks inside a backpack or two boxes inside a box. I don't think infinite fractal storage is desirable, balance wise.

RavingManiac · 2016-01-06T10:19:33Z

It doesn't allow containers to be placed inside other containers with equal or lesser w_class.

I initially made containers always have equal or less storage space than they take up, but this would have made boxes useless for increasing storage capacity, among other changes to gameplay balance.

Techhead0 · 2016-01-06T10:27:57Z

Ah. Thanks for clarifying that.
Honeybee Professor approves.

PsiOmegaDelta · 2016-01-06T16:26:35Z

👍

comma · 2016-01-07T04:16:48Z

Oh well what can possibly go wrong

Capacity-based storage system

headswe · 2016-01-08T08:53:56Z

Yay!

GinjaNinja32 reviewed Jul 10, 2015
View reviewed changes

GinjaNinja32 added feature labels Jul 10, 2015

RavingManiac reviewed Jul 10, 2015
View reviewed changes

RavingManiac changed the title ~~[WIP] Capacity-based storage system (help needed)~~ [WIP] Capacity-based storage system Jul 10, 2015

RavingManiac force-pushed the dev-2 branch from cedbba7 to 2e70745 Compare July 10, 2015 19:57

RavingManiac force-pushed the dev-2 branch from 2e70745 to 91ff7a6 Compare July 10, 2015 20:04

mwerezak reviewed Jul 11, 2015
View reviewed changes

RavingManiac force-pushed the dev-2 branch from 91ff7a6 to d798e5a Compare July 12, 2015 09:36

GinjaNinja32 removed the cannot merge label Sep 11, 2015

PsiOmegaDelta added the cannot merge label Oct 15, 2015

Merge branch 'dev' of https://github.com/Baystation12/Baystation12 in…

b405c57

…to dev

PsiOmegaDelta removed the cannot merge label Nov 19, 2015

MistakeNot4892 added cannot merge Priority: High labels Dec 16, 2015

Techhead0 reviewed Jan 4, 2016
View reviewed changes

RavingManiac added 2 commits January 4, 2016 19:25

Merge branch 'dev' of https://github.com/Baystation12/Baystation12 in…

6e82dfa

…to dev

Backpack and box storage capacity set to 16 and 8 respectively. Maxim…

a8cea38

…um w-class set to 4 and 3 respectively. Storage box sprite made lighter to improve visibility against dark backgrounds.

RavingManiac force-pushed the dev-2 branch from 93537dd to a8cea38 Compare January 5, 2016 14:26

comma added a commit that referenced this pull request Jan 7, 2016

Merge pull request #10095 from RavingManiac/dev-2

f7b0f27

Capacity-based storage system

comma merged commit f7b0f27 into Baystation12:dev Jan 7, 2016

Techhead0 mentioned this pull request Jan 15, 2016

[DEV][OVERSIGHT] Carrying capacity is too low #11984

Closed

PJB3005 mentioned this pull request Feb 27, 2016

Heavy bags should slow you down. vgstation-coders/vgstation13#8528

Closed

Neerti mentioned this pull request Apr 6, 2016

Ports Bay's new inventory system. PolarisSS13/Polaris#1368

Merged

Techhead0 mentioned this pull request May 6, 2016

Adjusts backpack storage capacities #12874

Closed

Capacity-based storage system #10095

Capacity-based storage system #10095

Conversation

RavingManiac commented Jul 10, 2015

Choose a reason for hiding this comment

mwerezak commented Jul 10, 2015

GinjaNinja32 commented Jul 10, 2015

Dennok commented Jul 10, 2015

RemieRichards commented Jul 10, 2015

mwerezak commented Jul 10, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scrdest commented Jul 10, 2015

RavingManiac commented Jul 10, 2015

mwerezak commented Jul 10, 2015

RavingManiac commented Jul 10, 2015

SkowronX commented Jul 10, 2015

Dennok commented Jul 10, 2015

SkowronX commented Jul 10, 2015

atlantiscze commented Jul 10, 2015

Dennok commented Jul 10, 2015

atlantiscze commented Jul 10, 2015

MistakeNot4892 commented Jul 11, 2015

Fox-McCloud commented Jul 11, 2015

mwerezak commented Jul 11, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dennok commented Jul 11, 2015

mwerezak commented Jul 11, 2015

RavingManiac commented Nov 8, 2015

RavingManiac commented Nov 19, 2015

MistakeNot4892 commented Dec 16, 2015

headswe commented Dec 20, 2015

RavingManiac commented Dec 22, 2015

headswe commented Jan 3, 2016

PsiOmegaDelta commented Jan 4, 2016

Choose a reason for hiding this comment

RavingManiac commented Jan 6, 2016

Techhead0 commented Jan 6, 2016

RavingManiac commented Jan 6, 2016

Techhead0 commented Jan 6, 2016

PsiOmegaDelta commented Jan 6, 2016

comma commented Jan 7, 2016

headswe commented Jan 8, 2016