Rewrites alarm handler for multi z functionality #20404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I mean, it does still make sense. How would a simple, low-power alarm on a faraway outpost transmit all the way back to the Torch? |
|
The same way radio communication does? |
|
Alerts from outposts (if we had any) currently already do not show on the modular console. I could add their z levels to the loop. They'd be visible from anywhere, but that would ICly just imply they have a strong signal. Does that sound good? |
comma
reviewed
Feb 2, 2018
| @@ -4,7 +4,6 @@ | |||
| nanomodule_path = /datum/nano_module/alarm_monitor/engineering | |||
| ui_header = "alarm_green.gif" | |||
| program_icon_state = "alert-green" | |||
| program_key_state = "atmos_key" | |||
There was a problem hiding this comment.
Not sure why that happened. Fixed.
Techhead0
approved these changes
Feb 2, 2018
PsiOmegaDelta
added a commit
that referenced
this pull request
Feb 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃啈
bugfix: Fixes alert monitors being red for away mission alerts.
bugfix: Fixes nonmodular atmos/alert consoles showing away mission alerts.
/:cl: