Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the autopilot function completely #23794

Closed
wants to merge 1 commit into from

Conversation

Roland410
Copy link
Contributor

馃啈Roland410:
:rscdel:Removes the autopilot function completely.
/馃啈
This function while good in theory, has been implemented in a way that only allows the ship to go straight to the set coordinates not paying any attention to obstacles in the way.
It often was a tool for griefing or bad antag gimmicks, but also resulted in a lot of new players thinking it was good then causing a lot of damage with it.

@Spookerton
Copy link
Member

I'm not sure I've ever seen the autopilot actually succeed at arriving at the coordinates you give it tbh.

@Roland410
Copy link
Contributor Author

It SHOULD stop at the destination, but honestly, you'll be lucky if you have a ship by then.

@ghost
Copy link

ghost commented Nov 15, 2018

I know some people (like me) use autopilot to fly to waypoints that have a clear shot - Not to the destination. Change the autopilot location like three times, and blammo. You're there intact.

@AtomicWorm
Copy link
Contributor

People are simply using the autopilot functionality wrong. That's no reason to remove it.

@afterthought2
Copy link
Contributor

Could call Astar on it if you want instead, so that it goes around obstacles.

But honestly, it's a good way of screwing yourself over right now if you don't know what you're doing: you click autopilot, assuming it's a good way to avoid fuckups, and it rams you into hazards instead.

@babydoll
Copy link
Contributor

@Baystation12/developers
Need a word of support by this time in 3 days (Thursday night)

@afterthought2
Copy link
Contributor

I think removing it is perhaps preferable to the current state. You could replace it with Astar, but the implementation might not be trivial due to the movement physics (you'd need to decompose into straight segments, and possibly course correct on mistakes). You could also try renaming it instead of the hard remove.

As it seems unpopular, might be a good candidate for forum deferral. If it wasn't unpopular, I'd have merged it, but as my feelings about it aren't that strong and there's no code-side issues that this solves, I don't feel like it in the present state.

@SierraKomodo
Copy link
Contributor

This PR will essentially solve #20659 by removing the conditions that cause that runtime.

@babydoll babydoll closed this Nov 23, 2018
@Roland410 Roland410 deleted the manualdrifting branch November 23, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants