Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes game year to 2307 #24419

Merged
merged 1 commit into from Feb 6, 2019
Merged

Changes game year to 2307 #24419

merged 1 commit into from Feb 6, 2019

Conversation

comma
Copy link
Contributor

@comma comma commented Feb 6, 2019 •
edited

We're going back, Marty.
馃啈
tweak: The year is 2307 now. Roleplay accordingly.
/:cl:

@EcklesFire
Copy link
Contributor

Is lore approve.

@Roland410
Copy link
Contributor

Wouldn't it make more sense to set it back to 2319 so it'd be easier to keep track of in-game?

@MistakeNot4892
Copy link
Contributor

MistakeNot4892 commented Feb 6, 2019 •
edited

Useful thing: https://www.timeanddate.com/calendar/repeating.html Helps finding a year that lines up with the day/calendar/etc.
EDIT: closest that lines up is 2307.

@comma
Changes game year to 2307
97fd331 
We're going back, Marty.
@EcklesFire
Copy link
Contributor

I'm cool with it being 2307 instead if it makes day things more consistent/nicer for people.

CakeQ
CakeQ approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@CakeQ CakeQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is ok

@Roland410
Copy link
Contributor

The whole 2319 thing would be better since it'd be current year + 300, not because of repeating or such.

@MistakeNot4892
Copy link
Contributor

For what it's worth, 2318 also lines up days.

@CakeQ
Copy link
Contributor

CakeQ commented Feb 6, 2019

For what it's worth, 2318 also lines up days.

might confuse people somehow being almost but not quite the same end number

@babydoll
Copy link
Contributor

babydoll commented Feb 6, 2019

changellog

@comma comma changed the title Changes game year to 2309 Changes game year to 2307 Feb 6, 2019
@babydoll babydoll merged commit f906674 into Baystation12:dev Feb 6, 2019
PsiOmegaDelta added a commit that referenced this pull request Feb 6, 2019
@PsiOmegaDelta
Automatic changelog generation for PR #24419 [ci skip]
da3ed93
@comma comma deleted the hopinloser branch February 6, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PsiOmegaDelta PsiOmegaDelta PsiOmegaDelta approved these changes

@CakeQ CakeQ CakeQ approved these changes

Assignees
No one assigned
Labels
Map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@comma @EcklesFire @Roland410 @MistakeNot4892 @CakeQ @babydoll @PsiOmegaDelta