-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
New pencode tags, more gas analyzer info, refactoring and bug fixes #26924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bxil
reviewed
Sep 5, 2019
Bxil
reviewed
Sep 5, 2019
Not sure moles should be in default mode of analyzer, maybe in detailed one? Same with total moles and volume, that's a lot of info to show in a thing that is usually spammed by non-engineers to see if pressure is changing. |
add moles and volume info to gas scanner
add new pencode tags for digital use only and some bug fixes
Reworked the scanner and edited the OP for more info |
comma
previously approved these changes
Sep 6, 2019
comma
approved these changes
Sep 7, 2019
PsiOmegaDelta
added a commit
that referenced
this pull request
Sep 9, 2019
Dibasic
added a commit
to Dibasic/SS13PaperworkSimulator
that referenced
this pull request
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored some comments and a ..() and removed an unused log string for admins, fixed robot inventory bug. Removed some trailing whitespace automatically.
Gas analyzers now have a switchable operation mode in the UI menu called switch modes with a new mode that shows total mole count and moles per gas in the mixture as well as volume of the mixture. Also added a codex entry to explain how all 3 modes work.
New pencode tags [pre] [fontblue] [fontred] [fontgreen] for digital use only (nanoword, emails, reports, software txt files, etc.) which cannot be used when writing with a pen on paper. [Pre] has a closing tag and all three fonts are universally closed with [/font]. Fonts just change the font color same as a multicolor pen does, and [pre] is the html
<pre>
tag that conserves whitespace spaces but apparently not tabs. Printing papers conserve them and can be scanned back into a device with a scanner module giving back the correct pencodes.馃啈 Nirnael
rscadd: Adds pencode tags [pre] [fontblue] [fontred] [fontgreen], with closing [/pre] and [/font] universal for the three fonts. They only work digitally with nanoword, emails, report editors and direct txt files. Font color gives color, [pre] gives monospace font and preserves whitespace spaces only and not tabs, e.g. for ascii art.
rscadd: Gas analyzers now show total moles, total volume and moles per gas, check codex for more info.
bugfix: Fixed robot inventory not updating automatically when dropping items which are stored back into it.
bugfix: Saving emails to a txt file on disk now works correctly and can be printed with the new tags.
/:cl: