Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pencode tags, more gas analyzer info, refactoring and bug fixes #26924

Merged
merged 5 commits into from
Sep 9, 2019
Merged

New pencode tags, more gas analyzer info, refactoring and bug fixes #26924

merged 5 commits into from
Sep 9, 2019

Conversation

Nirnael
Copy link
Contributor

@Nirnael Nirnael commented Sep 5, 2019

  • Refactored some comments and a ..() and removed an unused log string for admins, fixed robot inventory bug. Removed some trailing whitespace automatically.

  • Gas analyzers now have a switchable operation mode in the UI menu called switch modes with a new mode that shows total mole count and moles per gas in the mixture as well as volume of the mixture. Also added a codex entry to explain how all 3 modes work.

  • New pencode tags [pre] [fontblue] [fontred] [fontgreen] for digital use only (nanoword, emails, reports, software txt files, etc.) which cannot be used when writing with a pen on paper. [Pre] has a closing tag and all three fonts are universally closed with [/font]. Fonts just change the font color same as a multicolor pen does, and [pre] is the html <pre> tag that conserves whitespace spaces but apparently not tabs. Printing papers conserve them and can be scanned back into a device with a scanner module giving back the correct pencodes.

馃啈 Nirnael
rscadd: Adds pencode tags [pre] [fontblue] [fontred] [fontgreen], with closing [/pre] and [/font] universal for the three fonts. They only work digitally with nanoword, emails, report editors and direct txt files. Font color gives color, [pre] gives monospace font and preserves whitespace spaces only and not tabs, e.g. for ascii art.
rscadd: Gas analyzers now show total moles, total volume and moles per gas, check codex for more info.
bugfix: Fixed robot inventory not updating automatically when dropping items which are stored back into it.
bugfix: Saving emails to a txt file on disk now works correctly and can be printed with the new tags.
/:cl:

code/_helpers/text.dm Outdated Show resolved Hide resolved
code/_helpers/text.dm Outdated Show resolved Hide resolved
@comma
Copy link
Contributor

comma commented Sep 6, 2019

Not sure moles should be in default mode of analyzer, maybe in detailed one? Same with total moles and volume, that's a lot of info to show in a thing that is usually spammed by non-engineers to see if pressure is changing.

Nirnael added 2 commits September 6, 2019 23:30
add moles and volume info to gas scanner
add new pencode tags for digital use only and some bug fixes
@Nirnael
Copy link
Contributor Author

Nirnael commented Sep 6, 2019

Reworked the scanner and edited the OP for more info

comma
comma previously approved these changes Sep 6, 2019
@comma comma merged commit 1fb40cc into Baystation12:dev Sep 9, 2019
@Nirnael Nirnael deleted the workbranch branch September 10, 2019 13:35
Dibasic added a commit to Dibasic/SS13PaperworkSimulator that referenced this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants