Add antagonist vote fix #34636
Merged
Add antagonist vote fix #34636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SierraKomodo
previously requested changes
Jun 1, 2024
SierraKomodo
approved these changes
Jun 9, 2024
Co-authored-by: Sierra "SierraKomodo" Brown <sierrakomodo@hey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, no matter the vote result, Add antagonist vote can never really add any antags. This is an attempt to restore the intended functionality.
Additionaly, changes were made to antag spawn and antag check: Ckey is transferred, even if the player ghosted from their body and ghosts are no longer getting checked for the job or for the NO_ANTAG flag of their previous body. (Otherwise, it could spawn an empty body, if ckey isn't transferred correctly to the off-ship roles. Or totally prevent someone from spawning as an off-ship role, because of their last body with a specific job role, or if their body had NO_ANTAG flag (ex:mouses), even if they are already ghosts)
Changelog
馃啈 Builder13
bugfix: Add Antagonist vote can now add antags.
/:cl: