Dev-freeze fixes #4462
Merged
Dev-freeze fixes #4462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated update_icon() for pipes and manifolds to change the color instead of the sprite - updated subtypes to use global defines for colors instead of hard coded html refs - added an alpha tweak to hidden pipes for the sake of mapping (DM doesn't render semi-transparent icons correctly, but it does handle var/alpha tweaks) - this is overridden when the pipe is spawned in the game world with New() (Thinking about it, we could potentially do away with the transparent pipe sprites by just using the alpha variable. May do this later.) - fixed pipe painter - unwrenched pipes now inherit their source pipe color, and also inherit it when reattached to a pipe network again
- Fixed lighting issues in dorms (added APC to bedroom area, also gave cryo storage and dorm bedrooms their own area subtypes so light switches don't conflict anymore) - Fixed 0-2 cable "pixel_y = 1" offset (it was making a 1 pixel gap between south-to-end cables on the map) - Replaced research outpost piping with new subtypes - Fixed a broken air supply pipe running to the research outpost auxiliary storage area - Replaced a few plating turfs in space with airless platings
|
Thanks, wasn't quite sure how that worked. I'll commit it out. Is there any documentation on afterattack()? I couldn't find much on how it works. |
Oops. Thanks Segrain.
|
It's here. Basically, attackby() is called when thing clicks on thing, and if it doesn't return non-zero value, afterattack() is also called. |
- Fixed a few closets not adding items to their contents at round start (wardrobes have the same issue, but I've already fixed them on master)
|
Thanks Segrain. Also, added a couple more minor fixes based on forum feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4455
Fixes a few other map bugs (details in commit: 8fd0378)
Fixes and cleanup for my pipe standardization PR: #4385 (details in commit: f451fd4)