Sniper scope improvements, binoculars #6588
Conversation
…oom. Currently 11 tiles in the direction the user is facing. Zooming can now be done through the right-click menu. Binoculars added. Functionally similar to sniper scope. Adminspawn-only as of this commit.
…ed by attack_self().
| @@ -1306,6 +1306,10 @@ | |||
| var/obj/item/weapon/gun/energy/sniperrifle/s = locate() in src | |||
| if(s.zoom) | |||
| s.zoom() | |||
| if(locate(/obj/item/device/binoculars, contents)) | |||
There was a problem hiding this comment.
Does this actually work? Reference does not list locate(type,container), so it might be actually trying to locate a turf with coordinates (type, contents, null) using locate(X,Y,Z) signature, as only one that has more than 1 arguments.
Usually locate is used as in example two lines above - locate(type) in container
Also pretty sure you don't need to explicitly use 'contents', as that is implied 'in [atom]' is used
There was a problem hiding this comment.
Using 'locate(bar) in foo.contents' seems to be more reliable than just using 'in foo'. Pretty sure locate(foo,bar) will just return you a value of foo anywhere in the world and ignore bar.
|
If zooming is the same for binoculars and sniper scopes it would be nice if you could generalize the action of zooming into a proc and then reuse that in both items. |
…lies to binoculars and sniper rifle.
Sniper scope improvements, binoculars
Sniper rifle zoom now adds a client.pixel_x/y offset in addition to zoom. Currently 11 tiles in the direction the user is facing, keeping the user in the field of view, one tile away from the edge. Zooming can now be done through the right-click menu.
Binoculars added. Functionally similar to sniper scope. Adminspawn-only for now.