Skip to content

Commit

Permalink
CI: Unpin requests pip package
Browse files Browse the repository at this point in the history
The issue docker/docker-py#3113 seems to be resolved.
The pinned version of requests (2.28.1) is no longer compatible with the current
docker pip, resulting in errors like:

"Error connecting: Error while fetching server API version: Not supported URL scheme http+docker"

This commit allows pip to install requests according to its dependency tree.

Fixes: confidential-containers#381

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
  • Loading branch information
BbolroC committed May 23, 2024
1 parent 5a92d1a commit 12a9d15
Showing 1 changed file with 6 additions and 12 deletions.
18 changes: 6 additions & 12 deletions tests/e2e/ansible/start_docker_registry.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,13 @@
state: present
retries: 3
delay: 10
# The docker pip is needed by the docker_container ansible module itself.
- name: Install docker pip
# The docker and requests pip packages are required by the docker_container ansible module itself.
- name: Install docker and requests pip packages
pip:
name: docker
# Due to a bug in requests 2.29.0 we need to downgrade it
# see https://github.com/docker/docker-py/issues/3113
- name: Downgrade requests
shell: |
actual_version="$(pip3 show requests | grep Version | cut -d: -f2 | xargs)"
version_ge="$(echo -e "2.29.0\n$actual_version" | sort -V | head -1)"
if [ "$version_ge" = "2.29.0" ]; then
pip3 install requests==2.28.1
fi
name:
- docker
- requests
state: present
retries: 3
delay: 10
- name: Start a docker registry
Expand Down

0 comments on commit 12a9d15

Please sign in to comment.