Refactored env repo structure. #10
Conversation
asa1997
requested review from
panickervinod,
harimohanr,
Pranshu021,
sumodgeorge and
vasanthtech
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| __besman_echo_white "Removing dev environment for BeSman" | ||
| # cd $BESMAN_ENV_ROOT/$environment | ||
| git --git-dir=$BESMAN_ENV_ROOT/$environment/.git --work-tree=$BESMAN_ENV_ROOT/$environment status | grep -e "modified" -e "untracked" | ||
| if [[ "$?" == "0" ]]; then |
There was a problem hiding this comment.
SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| __besman_echo_violet "Dev environment for ${environment_name} created successfully" | ||
| else | ||
| __besman_echo_white "Removing existing version " | ||
| rm -rf $BESMAN_ENV_ROOT |
There was a problem hiding this comment.
💬 13 similar findings have been found in this PR
SC2086: Double quote to prevent globbing and word splitting.
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| BeSman/0.0.1/besman-BeSman-dev-env.sh | 35 |
| BeSman/0.0.1/besman-BeSman-dev-env.sh | 36 |
| BeSman/0.0.1/besman-BeSman-dev-env.sh | 36 |
| BeSman/0.0.1/besman-BeSman-dev-env.sh | 36 |
| BeSman/0.0.1/besman-BeSman-dev-env.sh | 36 |
| BeSman/0.0.1/besman-BeSman-dev-env.sh | 38 |
| BeSman/0.0.1/besman-BeSman-dev-env.sh | 42 |
| BeSman/0.0.1/besman-BeSman-dev-env.sh | 54 |
| BeSman/0.0.1/besman-BeSman-dev-env.sh | 54 |
| BeSman/0.0.1/besman-BeSman-dev-env.sh | 54 |
Showing 10 of 13 findings. Visit the Lift Web Console to see all.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Fixed #4