Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/no favicon #74

Merged
merged 2 commits into from
May 25, 2020
Merged

Feature/no favicon #74

merged 2 commits into from
May 25, 2020

Conversation

Cocola
Copy link
Contributor

@Cocola Cocola commented Sep 10, 2019

By removing custom favicons and app icons, we drop 200mb from our node_modules folder 馃コ
I delete the PHP services and test native WordPress support through the customizer, it work.
I just want you to check if it's ok for you.

NB: if a client want different design from favicon.ico in browser to an apple-touch-icon in iOS, i suggest to add second field dedicated to, in the customizer or theme option.

@asadowski10
Copy link
Member

@Cocola We disable customization on our projects to prevent customers from having additional options not used.

@Cocola Cocola mentioned this pull request Sep 10, 2019
5 tasks
@Cocola
Copy link
Contributor Author

Cocola commented Sep 10, 2019

@asadowski10 It will be used because favicon are no longer provided by BFF so we need a solution:

  • keep customizer
  • provide an equivalent solution in ACF theme option

We can slack on it if you want :)

@Rahe
Copy link
Member

Rahe commented Sep 16, 2019

This could be a great idea to move this kind of settings to the customizer, allowing SVGs to be uploaded.
We can selectively add/remove parts of the customizer and leave only the basics, removing the logo or this kind of stuff.
More, we can add to WordPress the missing sizes if needed.

@Cocola
Copy link
Contributor Author

Cocola commented Oct 14, 2019

@Rahe @asadowski10 Up, how can we handle favicons without customizer ?

@Cocola
Copy link
Contributor Author

Cocola commented Oct 22, 2019

@Cocola
Copy link
Contributor Author

Cocola commented Feb 10, 2020

@Rahe @herewithme @asadowski10 any news ?

@herewithme
Copy link
Member

pwa-wp c'est trop fat par rapport 脿 notre besoin.

@herewithme
Copy link
Member

@firestar300 on peut le virer au profit de la gestion native des favicons de WP.

@asadowski10
Copy link
Member

Pr茅voir une discussion en r茅union DEV pour cibler les impacts avant de le virer ;)
Exemple : ne plus mettre le plugin pour supprimer le customizer, pr茅venir la GDP que c'est 脿 eux de contribuer sur les 200000 sites d'une usine 脿 site etc ;) 莽a se pr茅pare quoi :D

@herewithme
Copy link
Member

C'est pas bloquant, go merge.

@asadowski10
Copy link
Member

ok le chef parle ;)
Faisons

@firestar300 firestar300 merged commit 82d8d31 into master May 25, 2020
@firestar300 firestar300 deleted the feature/no-favicon branch May 25, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants