-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/no favicon #74
Conversation
@Cocola We disable customization on our projects to prevent customers from having additional options not used. |
@asadowski10 It will be used because favicon are no longer provided by BFF so we need a solution:
We can slack on it if you want :) |
This could be a great idea to move this kind of settings to the customizer, allowing SVGs to be uploaded. |
@Rahe @asadowski10 Up, how can we handle favicons without customizer ? |
@Rahe @asadowski10 great no ? https://github.com/xwp/pwa-wp |
@Rahe @herewithme @asadowski10 any news ? |
pwa-wp c'est trop fat par rapport 脿 notre besoin. |
@firestar300 on peut le virer au profit de la gestion native des favicons de WP. |
Pr茅voir une discussion en r茅union DEV pour cibler les impacts avant de le virer ;) |
C'est pas bloquant, go merge. |
ok le chef parle ;) |
By removing custom favicons and app icons, we drop 200mb from our node_modules folder 馃コ
I delete the PHP services and test native WordPress support through the customizer, it work.
I just want you to check if it's ok for you.
NB: if a client want different design from favicon.ico in browser to an apple-touch-icon in iOS, i suggest to add second field dedicated to, in the customizer or theme option.