Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not passing event object to the handler breaks social login buttons in Firefox and IE #23

Closed
laszbalo opened this issue Oct 16, 2013 · 3 comments
Closed

Not passing event object to the handler breaks social login buttons in Firefox and IE #23

laszbalo opened this issue Oct 16, 2013 · 3 comments

Comments

@laszbalo
Copy link

I believe that in shared/social.coffee file on line 10 it should be 'click .btn': (event) -> instead of 'click .btn': ->.

Regards,
Laszlo
@ryw
Copy link
Contributor

ryw commented Oct 16, 2013

Agree - fixed 0167b45

@ryw ryw closed this as completed Oct 16, 2013
@queso
Copy link
Contributor

queso commented Oct 16, 2013

Really? I thought Meteor took care of passing the event object into all event handlers...

@ryw
Copy link
Contributor

ryw commented Oct 16, 2013

Yes, but IE/Firefox don't like it.

On Wed, Oct 16, 2013 at 9:49 AM, Josh Owens notifications@github.comwrote:

Really? I thought Meteor took care of passing the event object into all
event handlers...

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/23#issuecomment-26418891
.

-Ry

Ry Walker | Partner at Differential http://differential.io |
513.417.2163 | @RYWalker http://twitter.com/rywalker |
LinkedInhttp://www.linkedin.com/in/rywalker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@queso @ryw @laszbalo