store username with new user #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| email: email | ||
| password: password | ||
| profile: AccountsEntry.settings.defaultProfile || {} |
There was a problem hiding this comment.
Why are we nuking setting the profile here?
There was a problem hiding this comment.
I though I deleted this.
| email: email | ||
| password: password | ||
| profile: AccountsEntry.settings.defaultProfile || {} |
There was a problem hiding this comment.
I still think we don't want this line removed... Are you removing it on purpose for some reason?
|
Grr, this needs to be synced again. Other than the profile line, this looks good to go, just merge master in. |
|
merged and restored the profile line |
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR #81 can be discarded. Half of what PR #81 does has already be fixed by ryw with 1afc798.