-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store username with new user #86
Conversation
email: email | ||
password: password | ||
profile: AccountsEntry.settings.defaultProfile || {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we nuking setting the profile here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I though I deleted this.
email: email | ||
password: password | ||
profile: AccountsEntry.settings.defaultProfile || {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we don't want this line removed... Are you removing it on purpose for some reason?
Grr, this needs to be synced again. Other than the profile line, this looks good to go, just merge master in. |
merged and restored the profile line |
Nice work! |
With this PR #81 can be discarded. Half of what PR #81 does has already be fixed by ryw with 1afc798.