Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revealing sensitive images should also reveal CWed text #72

Closed
aarchiba opened this issue Jun 3, 2019 · 1 comment · Fixed by #83
Closed

Revealing sensitive images should also reveal CWed text #72

aarchiba opened this issue Jun 3, 2019 · 1 comment · Fixed by #83
Assignees
Labels
enhancement Improvement on existing features

Comments

@aarchiba
Copy link

aarchiba commented Jun 3, 2019

Currently: if a CWed post has images, you see the CW and blurred-out versions of the images. If you click on the images, they appear - but the toot body does not. It is easy to forget that there is text in the toot body. (But there always is because if there weren't the post would have had its CW status removed and the CW text would become the post body.)

I suggest: clicking on a sensitive image in a CWed toot reveals both image and body text. There are three states: CW and blurred image, CW and body text and blurred image, CW and body text and revealed image. (The fourth state, CW, hidden body, revealed image, is what I am suggesting removing.)

I also suggest: Clicking on "show more" does not reveal the image; this is just a feeling that there will be cases where users are comfortable with the text but unsure about viewing the image - especially without seeing the text first. I think images are more likely to have a visceral impact so we should be conservative about showing them.

@jebutton
Copy link
Collaborator

jebutton commented Jun 6, 2019

New tests are added to the TCM for "Verify that revealing sensitive images in a CW'd toot also expands the CW'd toot they're in." and "Verify that expanding a CW'd toot with a sensitive image doesn't reveal the sensitive image that is part of the toot."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing features
Projects
None yet
3 participants