Page Builder - enable the editor on New pages #172
Conversation
ChristianTovar
force-pushed
the
131-page-builder-enable-editor-on-new-pages
branch
from
9bf4d97
to
afcdb7c
Compare
| @@ -34,11 +34,15 @@ defmodule Beacon.LiveAdmin.PageEditorLive.New do | |||
| end | |||
|
|
|||
| defp build_new_page(site, [layout | _] = _layouts) do | |||
| id = Ecto.UUID.generate() | |||
There was a problem hiding this comment.
Instead of pre populating dummy data here that will be rendered in the form, what if we populate the data (only if it's empty) on the actual call to build the page ast? (the page ast is used on the visual editor only)
page is resolved from the changeset so if the required fields are present (id, title, path) then it should work, otherwise we could fill with dummy data to make the visual editor work. This way user won't see the dummy data on the form.
Wdyt?
There was a problem hiding this comment.
Okay, I've been trying to see what changes with your suggestion. I think populating just to make it render is fine, however populating at the LiveView level is also important because it not only helps rendering the visual editor but it also provided an appropriate state to the assigns so that the page can be drafted, saved and also published.
There was a problem hiding this comment.
@leandrocp Please take a look to the updated demo, drag and drop functionality has now been enabled and feature is fully functional!
There was a problem hiding this comment.
I think populating just to make it render is fine
We can go with that for this version 👍🏻
ChristianTovar
force-pushed
the
131-page-builder-enable-editor-on-new-pages
branch
from
31a5f3c
to
ca86272
Compare
ChristianTovar
force-pushed
the
131-page-builder-enable-editor-on-new-pages
branch
from
2144401
to
ab3feda
Compare
There was a problem hiding this comment.
Hey @ChristianTovar that looks good. What about changing the auto generated path with timestamp instead? (like you mentioned yesterday)
| @@ -34,11 +34,15 @@ defmodule Beacon.LiveAdmin.PageEditorLive.New do | |||
| end | |||
|
|
|||
| defp build_new_page(site, [layout | _] = _layouts) do | |||
| id = Ecto.UUID.generate() | |||
There was a problem hiding this comment.
I think populating just to make it render is fine
We can go with that for this version 👍🏻
ChristianTovar
force-pushed
the
131-page-builder-enable-editor-on-new-pages
branch
from
55d1dde
to
8aeb0f7
Compare
ChristianTovar
force-pushed
the
131-page-builder-enable-editor-on-new-pages
branch
from
c27e7a4
to
6df0229
Compare
Demo
demo.4.34.50.PM.mov