[BUG Fix] Fixes paths which may contains spaces #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheSecEng Thanks for providing a fix, but I'd like to avoid adding new dependencies. Could you just revert the last commit and As for prefixes, the current approach uses prettier if it's available on PATH env variable. And this should work on windows as well. |
|
@Beaglefoot will close this. This is the wrong changes ! Sorry |
|
Should be good now |
|
@TheSecEng Ok let me help you. You are currently 3 commits ahead of master. These are: To avoid adding unnecessary changes you need to do the following:
This completely removes the last 2 commits and updates current PR. |
|
Sorry I was a bit out of it yesterday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Paths which contain spaces break the
execcommand since the paths are not escaped and they are treated as separate strings.