Merge 17b4458 into 8e183ea

Beakerboy · Jul 28, 2019 · b4e0e89 · b4e0e89
2 parents 8e183ea + 17b4458
commit b4e0e89
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/Services/RequestGenerator.php b/src/Services/RequestGenerator.php
@@ -37,7 +37,7 @@ class RequestGenerator extends CashIDService
      * @return mixed
      *  returns the request URI or false if error
      */
-    public function createRequest(string $action = "", string $data = "", array $metadata = [])
+    public function createRequest(?string $action = "", ?string $data = "", ?array $metadata = [])
     {
         try {
             $user_generated = false;

diff --git a/tests/Unit/RequestGeneratorTest.php b/tests/Unit/RequestGeneratorTest.php
@@ -68,6 +68,18 @@ public function dataProviderForTestCreateRequest()
                 ],
                 "cashid:demo.cashid.info/api/parse.php?a=login&d=15366-4133-6141-9638&r=c3&o=p4&x=",
             ],
+            [ // Minimal with nulls
+                null,
+                null,
+                null,
+                'cashid:demo.cashid.info/api/parse.php?x=',
+            ],
+            [ // Minimal with empty
+                '',
+                '',
+                [],
+                'cashid:demo.cashid.info/api/parse.php?x=',
+            ],
         ];
     }