Apply major cleanup to the playfield judgement logic #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
June 14, 2020 05:52
…irely defined by the hit object Something I saw and didn't want to let it stay as-is.
MAy also be useful for adding our own `FeverIncreaseFor(...)` for fever mode later on.
fancy way to say fix build issue? idk :p
frenzibyte
changed the title
swoolcock
reviewed
Jun 14, 2020
| var r = (RushJudgementResult)br; | ||
|
|
||
| application?.Invoke(r); | ||
| r.PlayerCollided = drawableRuleset.PlayerCollidesWith(r.HitObject); |
There was a problem hiding this comment.
Is the player's position going to be correct at this time when rewinding? It's based solely on transforms triggered by prior actions.
There was a problem hiding this comment.
when rewinding, results would only be reverted as seen in DrawableHitObject.Update() (i.e. CheckForUpdate is never called, thus ApplyResult is never called), I've updated the boolean here as it is more correct since it'll remove the unintended direct connection between HealthProcessor and DrawableRuleset.
added 2 commits
June 14, 2020 09:03
|
@frenzibyte Resolve the conflicts and I'll merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My initial goal upon stepping on this was to fix rewinding on hit explosions, which was a simple
Expire() -> Expire(true), but I really didn't like how it is all out stuffed inside a method, so I tidied up the entire thing, hope it's readable and better than before.