Refactor the note sheet logic into being friendly with rewinding #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 14, 2020 07:14
Useful to the note sheet for knowing whether there is another action held on the same object, very friendly with rewinding instead of the `pressCount` way.
swoolcock
reviewed
Jun 14, 2020
|
Gonna go ahead and merge this for now, I'll do some more testing before the next tagged release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the title, the note sheet was very unfriendly with rewinding as it relied on variables and values set without being reverted on rewinding, this fixes and refactors the entire logic by almost always relying on judgement results of the note sheet nested objects when checking in a certain method.