Refactor Encoder #584
Merged
Refactor Encoder #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsakkis
force-pushed
the
refactor-encoder
branch
7 times, most recently
from
47bcfe2
to
52d6560
Compare
|
Hi! Sorry for the delay. |
|
Can we merge this PR on priority? I am getting issue with Numpy array with beanie. |
gsakkis
force-pushed
the
refactor-encoder
branch
from
52d6560
to
ec8ae4d
Compare
|
Hey @gsakkis, |
gsakkis
force-pushed
the
refactor-encoder
branch
from
ec8ae4d
to
28712de
Compare
|
@roman-right all conflicts have been resolved. |
|
Thank you! It will be published by the end of this week together with others |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a stab at simplifying the
encodermodule a bit.