Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle TypeError in validator of PydanticObjectId #861

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

grthr
Copy link
Contributor

@grthr grthr commented Feb 15, 2024

the initializer of bson.ObjectId might raise TypeError(f"id must be an instance of (bytes, str, ObjectId), not {type(oid)}").

Pydantic validators should raise ValueErrors or AssertionErrors instead.

@roman-right
Copy link
Member

Thank you for the PR! It will be published soon

@roman-right roman-right merged commit cad8960 into BeanieODM:main Feb 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants