Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(classification): backport Ruby and C# test cases and KPIs #101

Merged
merged 8 commits into from
Nov 16, 2022

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Nov 7, 2022

Description

For Ruby and C# cases:

  • Deduplicate input and output CSVs into a JSON file, and include object classifications where missing.
  • Add test helper to construct expected and actual Classification objects and KPIs from JSON file
  • Snapshot the results - actual valid classifications and KPIs
  • Some fixes to the algorithm e.g.
    • Exclude objects with blank names
    • For unknown objects, check fields for DB identifiers (we updated the Miro flow to include this edge case)

Still TODO (later PR)

  • Other languages

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@swarmia
Copy link

swarmia bot commented Nov 7, 2022

@elsapet elsapet force-pushed the AMA-3087-backport-test-cases-from-ama branch 3 times, most recently from b4f5c3a to ef7bcee Compare November 10, 2022 16:17
@elsapet elsapet force-pushed the AMA-3087-backport-test-cases-from-ama branch 5 times, most recently from 16e27d7 to d4855ac Compare November 15, 2022 08:19
@elsapet elsapet marked this pull request as ready for review November 15, 2022 08:20
cfabianski
cfabianski previously approved these changes Nov 15, 2022
@elsapet elsapet changed the title feat(classification): backport test cases and KPIs feat(classification): backport Ruby and C# test cases and KPIs Nov 16, 2022
@elsapet
Copy link
Contributor Author

elsapet commented Nov 16, 2022

@cfabianski could you re-approve when you've a moment? I rebased, sorry! 🙈

@elsapet elsapet merged commit 0ab09c1 into main Nov 16, 2022
@elsapet elsapet deleted the AMA-3087-backport-test-cases-from-ama branch November 16, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants