Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefer fingerprint to fingerprints to match other flags #1022

Merged
merged 2 commits into from
May 31, 2023

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented May 31, 2023

Description

Fix to follow convention of other list flags e.g. skip-rule, only-rule, skip-path we change exclude-fingerprints to exclude-fingerprint (single). We keep the exclude terminology since we are not skipping anything here (that is, the findings are still "found"); we are simply excluding them from showing up in the report

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet requested review from cfabianski and didroe May 31, 2023 09:53
@elsapet elsapet merged commit 4d3f86b into main May 31, 2023
5 checks passed
@elsapet elsapet deleted the fix/fix-typo-in-flag branch May 31, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants