fix: result scope following testing #1024

didroe · 2023-05-31T13:31:54Z

Description

Fixes effectiveScope by ensuring we only convert nested scope to result scope. Prior to this change, we were converting cursor scope into result scope.
Run sanitizer rules in the default nested scope

I've added test coverage that shows my fix or feature works as expected.
I've updated or added documentation if required.
I've included usage information in the description if CLI behavior was updated or added.
PR title follows Conventional Commits format

new/detector/implementation/custom/filter.go

Co-authored-by: elsapet <elizabeth@bearer.sh>

didroe requested a review from elsapet May 31, 2023 13:31

fix: result scope following testing

ad90ee9

didroe force-pushed the fix/result-scope branch from 7de3866 to ad90ee9 Compare May 31, 2023 13:32

elsapet approved these changes May 31, 2023

View reviewed changes

new/detector/implementation/custom/filter.go Outdated Show resolved Hide resolved

didroe and others added 2 commits May 31, 2023 14:56

refactor: review

6ec8eea

Co-authored-by: elsapet <elizabeth@bearer.sh>

test: remove conflict due to parallelism

3a3e24b

didroe merged commit 077a311 into main May 31, 2023
5 checks passed

didroe deleted the fix/result-scope branch May 31, 2023 14:16