Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update classification patterns #120

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Nov 14, 2022

Description

  • Update classification JSON following updates in Rails app
  • Also update scripts to include ID number in file name (this was the case for the old filenames, but the script did not reflect it)

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet
Copy link
Contributor Author

elsapet commented Nov 14, 2022

Trying to keep the KPI PR small so I made these changes in a separate PR /cc @cfabianski

@elsapet elsapet merged commit 7ba6125 into main Nov 14, 2022
@elsapet elsapet deleted the fix/update-classification-patterns branch November 14, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants