Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: More minor output stream consolidation #122

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

spdawson
Copy link
Contributor

Description

  • Use the Cobra standard error writer directly for the informational output of the init command
  • Use the global error writer consistently for the progress bar: both the bar itself and the terminating newline should use the same writer

Related

Follow-up for #105

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

Follow-up for #105

* Use the Cobra standard error writer directly for the informational
output of the `init` command
* Use the global error writer consistently for the progress bar: both
the bar itself and the terminating newline should use the same writer
@spdawson spdawson force-pushed the chore-more-output-stream-consolidation branch from 18cac15 to 3da8724 Compare November 15, 2022 08:48
Copy link
Collaborator

@cfabianski cfabianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these little fixes!

@spdawson spdawson merged commit 21f31c0 into main Nov 15, 2022
@spdawson spdawson deleted the chore-more-output-stream-consolidation branch November 15, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants