Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(policies): add risk severity via data category #124

Merged
merged 8 commits into from
Nov 17, 2022

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Nov 16, 2022

Description

  • Update RiskDatatype type to include data type category
  • Update logger_leaks policy to output locations with severity
  • Update Policy type to include Name and Description, and pass these to rego policies
  • Add data categories to DB and use these in policies.GetOutput

New logger policy output


=> go run cmd/curio/main.go scan ~/test --report=policies
=> [
  {
    "result": [
      {
        "data_type": "Physical Address",
        "filename": "temp.rb",
        "line_number": 1,
        "policy_description": "Logger leaks detected",
        "policy_id": "detect_ruby_logger",
        "policy_name": "Logger leaks",
        "severity": "high"
      },
      {
        "data_type": "Unique Identifier",
        "filename": "temp.rb",
        "line_number": 1,
        "policy_description": "Logger leaks detected",
        "policy_id": "detect_ruby_logger",
        "policy_name": "Logger leaks",
        "severity": "critical"
      }
    ]
  }
]

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@swarmia
Copy link

swarmia bot commented Nov 16, 2022

@elsapet elsapet force-pushed the AMA-3204-add-data-category-severity-to-the-policy branch 2 times, most recently from ea1baae to 254bc01 Compare November 17, 2022 11:06
@elsapet elsapet force-pushed the AMA-3204-add-data-category-severity-to-the-policy branch from e2e434e to 5733994 Compare November 17, 2022 11:21
vjerci
vjerci previously approved these changes Nov 17, 2022
Copy link
Contributor

@vjerci vjerci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

pkg/commands/process/settings/settings.go Outdated Show resolved Hide resolved
scripts/main.rb Show resolved Hide resolved
@elsapet elsapet force-pushed the AMA-3204-add-data-category-severity-to-the-policy branch from 5733994 to 0fba4fc Compare November 17, 2022 13:56
@elsapet elsapet marked this pull request as ready for review November 17, 2022 14:03
@cfabianski
Copy link
Collaborator

What do you think about getting this output instead?

 [
   {
      "data_type": "Physical Address",
      "filename": "temp.rb",
      "line_number": 1,
      "severity": "high",
      "policy_description": "Logger leaks detected",
      "policy_id": "detect_ruby_logger",
      "policy_name": "Logger leaks"
    },
    {
      "data_type": "Unique Identifier",
      "filename": "temp.rb",
      "line_number": 1,
      "severity": "critical",
      "policy_description": "Logger leaks detected",
      "policy_id": "detect_ruby_logger",
      "policy_name": "Logger leaks"
    }
]

feat: add policy "id" to policy type
@elsapet elsapet force-pushed the AMA-3204-add-data-category-severity-to-the-policy branch from 3601a24 to d737e62 Compare November 17, 2022 14:34
@elsapet
Copy link
Contributor Author

elsapet commented Nov 17, 2022

@cfabianski I can get something like this:

[
  {
    "result": [
      {
        "data_type": "Physical Address",
        "filename": "temp.rb",
        "line_number": 1,
        "policy_description": "Logger leaks detected",
        "policy_id": "detect_ruby_logger",
        "policy_name": "Logger leaks",
        "severity": "high"
      },
      {
        "data_type": "Unique Identifier",
        "filename": "temp.rb",
        "line_number": 1,
        "policy_description": "Logger leaks detected",
        "policy_id": "detect_ruby_logger",
        "policy_name": "Logger leaks",
        "severity": "critical"
      }
    ]
  }
]

I don't know how to return just the "results" array (below), as you're asking for. @vjerci do you know if this is possible in rego?

[
      {
        "data_type": "Physical Address",
        "filename": "temp.rb",
        "line_number": 1,
        "policy_description": "Logger leaks detected",
        "policy_id": "detect_ruby_logger",
        "policy_name": "Logger leaks",
        "severity": "high"
      },
      {
        "data_type": "Unique Identifier",
        "filename": "temp.rb",
        "line_number": 1,
        "policy_description": "Logger leaks detected",
        "policy_id": "detect_ruby_logger",
        "policy_name": "Logger leaks",
        "severity": "critical"
      }
]

@elsapet elsapet merged commit aecc710 into main Nov 17, 2022
@elsapet elsapet deleted the AMA-3204-add-data-category-severity-to-the-policy branch November 17, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants