Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Backport Rails framework classification #133

Merged
merged 10 commits into from
Nov 21, 2022

Conversation

spdawson
Copy link
Contributor

@spdawson spdawson commented Nov 18, 2022

Description

Create basic structure for framework classification. In this initial implementation, only the Rails framework is classified; the other frameworks will be classified in future work.

Sample YAML output for detectors report:

- classification:
    Decision:
        reason: recipe_match
        state: valid
    recipe_match: true
    recipe_name: PostgreSQL
  detector_type: rails
  source:
    column_number: null
    filename: config/database.yml
    language: YAML
    language_type: data
    line_number: 85
    text: null
  type: framework_classified
  value:
    adapter: postgresql
    name: ""

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@swarmia
Copy link

swarmia bot commented Nov 18, 2022

cfabianski
cfabianski previously approved these changes Nov 18, 2022
pkg/classification/frameworks/frameworks.go Outdated Show resolved Hide resolved
elsapet
elsapet previously approved these changes Nov 18, 2022
@spdawson spdawson force-pushed the AMA-3194-create-framework-classifier branch from f869fe0 to 2e31a16 Compare November 18, 2022 10:07
@spdawson spdawson changed the title chore: Create framework classifier feat: Backport Rails framework classification from AMA Nov 18, 2022
@spdawson spdawson changed the title feat: Backport Rails framework classification from AMA feat: Backport Rails framework classification Nov 18, 2022
@spdawson spdawson force-pushed the AMA-3194-create-framework-classifier branch from 2e31a16 to 5aa2f7f Compare November 18, 2022 10:13
Copy link
Collaborator

@cfabianski cfabianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small question (@elsapet might be interested as well)
Otherwise, that looks good

cfabianski
cfabianski previously approved these changes Nov 18, 2022
elsapet
elsapet previously approved these changes Nov 18, 2022
Copy link
Contributor

@elsapet elsapet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👏

@spdawson spdawson dismissed stale reviews from elsapet and cfabianski via e45a40b November 18, 2022 11:04
@spdawson spdawson force-pushed the AMA-3194-create-framework-classifier branch 2 times, most recently from e45a40b to c3ab862 Compare November 18, 2022 11:17
elsapet
elsapet previously approved these changes Nov 18, 2022
@spdawson spdawson merged commit 7067247 into main Nov 21, 2022
@spdawson spdawson deleted the AMA-3194-create-framework-classifier branch November 21, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants