-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Backport Rails framework classification #133
Conversation
✅ Linked to AMA-3194 · Create framework classifier |
f869fe0
to
2e31a16
Compare
2e31a16
to
5aa2f7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small question (@elsapet might be interested as well)
Otherwise, that looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👏
e45a40b
to
c3ab862
Compare
Also add a test case covering the associated code path
All other similar calls pass the framework information by value
c3ab862
to
61a4af5
Compare
Description
Create basic structure for framework classification. In this initial implementation, only the Rails framework is classified; the other frameworks will be classified in future work.
Sample YAML output for detectors report:
Checklist