fix(classification): include classification errors as debug rather than report errors #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to AMA-3081 · Stop including classification errors in report |
elsapet
changed the title
elsapet
force-pushed
the
AMA-3081-stop-including-classification-errors-in-report
branch
from
22df593
to
110c6a3
Compare
spdawson
approved these changes
Nov 21, 2022
elsapet
deleted the
AMA-3081-stop-including-classification-errors-in-report
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Swallows errors from the interface/URL classifier unless we are in debug mode
Why?
They're not useful (i.e. the scan user can't address them) and can be quite noisy
Checklist