feat: stop exporting object-level data types

[elsapet]

Description

Stop exporting object data types, only their properties

Fixes unexpected report output

Before:

[
  {
    "detector_type": "detect_ruby_logger",
    "source": {
      "column_number": 1,
      "filename": ".",
      "language": "Ruby",
      "language_type": "programming",
      "line_number": 2,
      "text": null
    },
    "type": "custom_classified",
    "value": {
      "classification": {
        "data_type": {
          "data_category_name": "Unique Identifier",
          "default_category": "Identification",
          "id": 86,
          "uuid": "12d44ae0-1df7-4faf-9fb1-b46cc4b4dce9"
        },
        "decision": {
          "reason": "valid_object_with_valid_properties",
          "state": "valid"
        },
        "name": "user"
      },
      "field_name": "user",
      "field_type": "",
      "field_type_simple": "unknown",
      "object_name": ""
    }
  },
  {
    "detector_type": "detect_ruby_logger",
    "source": {
      "column_number": 6,
      "filename": ".",
      "language": "Ruby",
      "language_type": "programming",
      "line_number": 2,
      "text": null
    },
    "type": "custom_classified",
    "value": {
      "classification": {
        "data_type": {
          "data_category_name": "Physical Address",
          "default_category": "Contact",
          "id": 13,
          "uuid": "5a80a938-6fb2-4d9a-9c47-8d377e036506"
        },
        "decision": {
          "reason": "known_pattern",
          "state": "valid"
        },
        "name": "address"
      },
      "field_name": "address",
      "field_type": "",
      "field_type_simple": "unknown",
      "object_name": "user"
    }
  },
  {
    "detector_type": "ruby",
    "source": {
      "column_number": 8,
      "filename": ".",
      "language": "Ruby",
      "language_type": "programming",
      "line_number": 2,
      "text": null
    },
    "type": "schema_classified",
    "value": {
      "classification": null,
      "field_name": "info",
      "field_type": "",
      "field_type_simple": "unknown",
      "object_name": "logger"
    }
  },
  {
    "detector_type": "ruby",
    "source": {
      "column_number": 18,
      "filename": ".",
      "language": "Ruby",
      "language_type": "programming",
      "line_number": 2,
      "text": null
    },
    "type": "schema_classified",
    "value": {
      "classification": {
        "data_type": {
          "data_category_name": "Physical Address",
          "default_category": "Contact",
          "id": 13,
          "uuid": "5a80a938-6fb2-4d9a-9c47-8d377e036506"
        },
        "decision": {
          "reason": "known_pattern",
          "state": "valid"
        },
        "name": "address"
      },
      "field_name": "address",
      "field_type": "",
      "field_type_simple": "unknown",
      "object_name": "user"
    }
  }
]

After:

[
  {
    "detector_type": "detect_ruby_logger",
    "source": {
      "column_number": 6,
      "filename": ".",
      "language": "Ruby",
      "language_type": "programming",
      "line_number": 2,
      "text": null
    },
    "type": "custom_classified",
    "value": {
      "classification": {
        "data_type": {
          "data_category_name": "Physical Address",
          "default_category": "Contact",
          "id": 13,
          "uuid": "5a80a938-6fb2-4d9a-9c47-8d377e036506"
        },
        "decision": {
          "reason": "known_pattern",
          "state": "valid"
        },
        "name": "address"
      },
      "field_name": "address",
      "field_type": "",
      "field_type_simple": "unknown",
      "object_name": "user"
    }
  },
  {
    "detector_type": "ruby",
    "source": {
      "column_number": 8,
      "filename": ".",
      "language": "Ruby",
      "language_type": "programming",
      "line_number": 2,
      "text": null
    },
    "type": "schema_classified",
    "value": {
      "classification": null,
      "field_name": "info",
      "field_type": "",
      "field_type_simple": "unknown",
      "object_name": "logger"
    }
  },
  {
    "detector_type": "ruby",
    "source": {
      "column_number": 18,
      "filename": ".",
      "language": "Ruby",
      "language_type": "programming",
      "line_number": 2,
      "text": null
    },
    "type": "schema_classified",
    "value": {
      "classification": {
        "data_type": {
          "data_category_name": "Physical Address",
          "default_category": "Contact",
          "id": 13,
          "uuid": "5a80a938-6fb2-4d9a-9c47-8d377e036506"
        },
        "decision": {
          "reason": "known_pattern",
          "state": "valid"
        },
        "name": "address"
      },
      "field_name": "address",
      "field_type": "",
      "field_type_simple": "unknown",
      "object_name": "user"
    }
  }
]

Checklist

• I've added test coverage that shows my fix or feature works as expected.
• I've updated or added documentation if required.
• I've included usage information in the description if CLI behavior was updated or added.
• PR title follows Conventional Commits format

[swarmia]

✅  Linked to AMA-3148 · Switch detectors so that first object name is empty
➡️  Part of AMA-2947 · OSS - Curio CLI

[cfabianski]

That looks good (even the test failures look legit) but let's double check and fix them and see what the end result really is :)

[elsapet]

thanks @cfabianski - snapshot updates look like they are all removing the instances of "object_name": "" which is what we'd would expect, I think

[elsapet]

Apologies I had to rebase 🙈