Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(policies): policy determines severity of policy breach #152

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Nov 22, 2022

Description

  • Add category "groups" (personal, sensitive - could be PII, PHI) with a mapping for customisability
  • In logger policy, set severity based on category group
  • In logger policy, remove data type name and add category group name

Having policies determine severity level is more flexible and allows different policies to have different severity levels for e.g. different categories. Of course, not all policies will care about data categories, but the severity concept will be inside policies themselves.

Output now with category group (Sensitive, Personal data) instead of data type:

[
  {
    "result": [
      {
        "category_group": "Personal data",
        "filename": ".",
        "line_number": 3,
        "policy_description": "Logger leaks detected",
        "policy_id": "detect_ruby_logger",
        "policy_name": "Logger leaks",
        "severity": "high"
      },
      {
        "category_group": "Personal data",
        "filename": ".",
        "line_number": 5,
        "policy_description": "Logger leaks detected",
        "policy_id": "detect_ruby_logger",
        "policy_name": "Logger leaks",
        "severity": "high"
      },
      {
        "category_group": "Personal data",
        "filename": ".",
        "line_number": 10,
        "policy_description": "Logger leaks detected",
        "policy_id": "detect_ruby_logger",
        "policy_name": "Logger leaks",
        "severity": "high"
      },
      {
        "category_group": "Sensitive data",
        "filename": ".",
        "line_number": 4,
        "policy_description": "Logger leaks detected",
        "policy_id": "detect_ruby_logger",
        "policy_name": "Logger leaks",
        "severity": "critical"
      }
    ]
  }
]
]

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet force-pushed the AMA-3243-add-mapping-between-data-category-and-phi-pii-and-use-to-calculate-policy-severity branch from 533971e to 9fe86ed Compare November 22, 2022 12:52
@elsapet elsapet force-pushed the AMA-3243-add-mapping-between-data-category-and-phi-pii-and-use-to-calculate-policy-severity branch from 35bc37c to 2a576b5 Compare November 23, 2022 10:07
@elsapet elsapet merged commit 9437d97 into main Nov 23, 2022
@elsapet elsapet deleted the AMA-3243-add-mapping-between-data-category-and-phi-pii-and-use-to-calculate-policy-severity branch November 23, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants