Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python): handle string line continuation #1610

Merged
merged 1 commit into from
May 23, 2024
Merged

fix(python): handle string line continuation #1610

merged 1 commit into from
May 23, 2024

Conversation

didroe
Copy link
Contributor

@didroe didroe commented May 23, 2024

Description

Workaround line continuation issue with Python strings.

Python string line continuation is incorrectly represented as an escape character by the tree sitter parser. This causes the detector to fail when trying to interpret it.

Checklist

If this is your first time contributing please sign the CLA

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.

@didroe didroe requested a review from elsapet May 23, 2024 09:56
elsapet
elsapet approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@elsapet elsapet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@didroe didroe merged commit d1b8357 into main May 23, 2024
8 checks passed
@didroe didroe deleted the fix/python-handle-string-continuation branch May 23, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsapet elsapet elsapet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@didroe @elsapet