Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(policies): include code excerpt in policy breach display #164

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Nov 24, 2022

Description

Aim

  • Add code extract with parent source and minimal highlighting to policy breach display
  • Add full file path to policy breach display

To achieve the aim, I made some changes elsewhere in code:

  • Add Target (i.e. the path the user asks us to scan) to settings.Config
  • Separate schema decoding from classification decoding

Results:

Screenshot 2022-11-25 at 13 32 59

Default setting

Screenshot 2022-11-25 at 13 32 43

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@swarmia
Copy link

swarmia bot commented Nov 24, 2022

@elsapet elsapet force-pushed the AMA-3245-include-code-excerpt-in-policy-breach-display branch 2 times, most recently from e2e2c1e to a9c6965 Compare November 25, 2022 11:30
@elsapet elsapet marked this pull request as ready for review November 25, 2022 11:33
@elsapet elsapet requested a review from vjerci November 25, 2022 12:19
@elsapet elsapet force-pushed the AMA-3245-include-code-excerpt-in-policy-breach-display branch from a9c6965 to e978749 Compare November 28, 2022 07:55
@elsapet
Copy link
Contributor Author

elsapet commented Nov 28, 2022

@cfabianski could you review when you have a moment? 🙏

@elsapet elsapet merged commit 977b62f into main Nov 28, 2022
@elsapet elsapet deleted the AMA-3245-include-code-excerpt-in-policy-breach-display branch November 28, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants