Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run classifier for schema detections #165

Conversation

spdawson
Copy link
Contributor

@spdawson spdawson commented Nov 24, 2022

Description

Classify data types for schema detections. Covers the following detector types.

  • SQL ("create table")
  • Rails personal data
  • GraphQL
  • protobuf
  • OpenAPI

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@swarmia
Copy link

swarmia bot commented Nov 24, 2022

Copy link
Collaborator

@cfabianski cfabianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice so far

@spdawson spdawson force-pushed the AMA-3202-run-classifier-when-we-add-a-schema-detection-to-the-report branch 3 times, most recently from 5e338e5 to 6bebd2e Compare November 25, 2022 14:01
@spdawson spdawson force-pushed the AMA-3202-run-classifier-when-we-add-a-schema-detection-to-the-report branch from 6bebd2e to 1e02b3d Compare November 29, 2022 09:01
@spdawson spdawson force-pushed the AMA-3202-run-classifier-when-we-add-a-schema-detection-to-the-report branch from 1e02b3d to 47761cf Compare November 29, 2022 09:07
@spdawson spdawson marked this pull request as ready for review November 29, 2022 09:12
@spdawson spdawson merged commit 4564134 into main Nov 29, 2022
@spdawson spdawson deleted the AMA-3202-run-classifier-when-we-add-a-schema-detection-to-the-report branch November 29, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants