Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(policies): add summary with counts to policy report #168

Merged
merged 5 commits into from
Nov 28, 2022
Merged

feat(policies): add summary with counts to policy report #168

merged 5 commits into from
Nov 28, 2022

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Nov 25, 2022

Description

Add summary to policy report, to count number of policies run and number of breaches, with a breakdown by severity level.

This is shown even if no policy breaches have been detected

Example output:

Start of report (title and list of all policies to be run)

Screenshot 2022-11-25 at 15 26 03

End of report (summary & breakdown)

Screenshot 2022-11-25 at 15 25 55

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@swarmia
Copy link

swarmia bot commented Nov 25, 2022

✅  Linked to AMA-3262 · Add summary with counts to report
➡️  Part of AMA-3235 · Table format for policies
➡️  Part of AMA-2947 · OSS - Curio CLI

@elsapet elsapet force-pushed the AMA-3262-add-summary-with-counts-to-report branch from e0a1627 to 5250c41 Compare November 25, 2022 15:45
@elsapet elsapet force-pushed the AMA-3245-include-code-excerpt-in-policy-breach-display branch from a9c6965 to e978749 Compare November 28, 2022 07:55
@elsapet elsapet force-pushed the AMA-3262-add-summary-with-counts-to-report branch from 5250c41 to 1d6ea02 Compare November 28, 2022 08:11
Base automatically changed from AMA-3245-include-code-excerpt-in-policy-breach-display to main November 28, 2022 08:50
@elsapet elsapet force-pushed the AMA-3262-add-summary-with-counts-to-report branch from 427d544 to 454fb03 Compare November 28, 2022 08:51
@elsapet elsapet marked this pull request as ready for review November 28, 2022 09:14
@elsapet elsapet merged commit b9c4f0e into main Nov 28, 2022
@elsapet elsapet deleted the AMA-3262-add-summary-with-counts-to-report branch November 28, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

@vjerci vjerci Awaiting requested review from vjerci

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elsapet @cfabianski