Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Policy for Rails insecure SMTP communication #181

Merged
merged 10 commits into from
Dec 1, 2022
Merged

feat: Policy for Rails insecure SMTP communication #181

merged 10 commits into from
Dec 1, 2022

Conversation

spdawson
Copy link
Contributor

Description

Add custom detection and policy for use of insecure SMTP in Rails' Action Mailer configuration.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@swarmia
Copy link

swarmia bot commented Nov 30, 2022

✅  Linked to AMA-3295 · Communication with insecure SMTP in an application processing sensitive data
➡️  Part of AMA-3280 · Write ALL Ruby custom detectors & policies
➡️  Part of AMA-2947 · OSS - Curio CLI

@spdawson spdawson force-pushed the AMA-3295-communication-with-insecure-smtp-in-an-application-processing-sensitive-data branch 4 times, most recently from aa39ca7 to 46f8316 Compare December 1, 2022 10:38
@spdawson spdawson force-pushed the AMA-3295-communication-with-insecure-smtp-in-an-application-processing-sensitive-data branch from 46f8316 to acba5e0 Compare December 1, 2022 13:27
@spdawson spdawson marked this pull request as ready for review December 1, 2022 13:35
@spdawson spdawson merged commit 01c41b2 into main Dec 1, 2022
@spdawson spdawson deleted the AMA-3295-communication-with-insecure-smtp-in-an-application-processing-sensitive-data branch December 1, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

@vjerci vjerci Awaiting requested review from vjerci

@elsapet elsapet Awaiting requested review from elsapet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spdawson @cfabianski