feat: policy for sending data in HTTP GET requests #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to AMA-3072 · Support multiple options indentifiers |
4 tasks
didroe
force-pushed
the
AMA-3072/add-multiple-identifiers
branch
from
5f611b0
to
c91ee69
Compare
didroe
force-pushed
the
AMA-3072/add-multiple-identifiers
branch
from
c039693
to
2b47b0d
Compare
didroe
force-pushed
the
AMA-3072/add-multiple-identifiers
branch
from
2b47b0d
to
d0804b8
Compare
cfabianski
approved these changes
Dec 1, 2022
cfabianski
reviewed
Dec 1, 2022
| newScanTest("ruby", "detect_ruby_logger", "detect_ruby_logger.rb"), | ||
| newScanTest("ruby", "ruby_file_detection", "ruby_file_detection.rb"), | ||
| newScanTest("ruby", "detect_rails_session", "detect_rails_session.rb"), | ||
| newScanTest("ruby", "detect_rails_jwt", "detect_rails_jwt.rb"), | ||
| // newScanTest("ruby", "ruby_http_detection", "ruby_http_detection.rb"), |
There was a problem hiding this comment.
@vjerci apparently there is an issue with the CI. This is definitely passing locally. Could you have a look at this test (why it triggers the worker more than once and stuff please?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds custom detectors for Ruby HTTP GET/POST requests, along with a policy to find GET requests being sent personal/sensitive data.
Checklist