Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Detect Net::FTP.open in Ruby custom detector #200

Merged
merged 1 commit into from
Dec 6, 2022
Merged

fix: Detect Net::FTP.open in Ruby custom detector #200

merged 1 commit into from
Dec 6, 2022

Conversation

spdawson
Copy link
Contributor

@spdawson spdawson commented Dec 6, 2022

Description

As well as Net::FTP.new, we also need to support the Net::FTP.open API, for the Ruby insecure FTP policy.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@spdawson spdawson force-pushed the fix/support-open-API-for-Ruby-Net-FTP branch from 06b0108 to b2cc55f Compare December 6, 2022 15:40
@cfabianski cfabianski merged commit 5ce532e into main Dec 6, 2022
@cfabianski cfabianski deleted the fix/support-open-API-for-Ruby-Net-FTP branch December 6, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spdawson @cfabianski