Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sort risk locations in a consistent order #202

Merged
merged 1 commit into from
Dec 6, 2022
Merged

fix: sort risk locations in a consistent order #202

merged 1 commit into from
Dec 6, 2022

Conversation

didroe
Copy link
Contributor

@didroe didroe commented Dec 6, 2022 •
edited
Loading

Description

Sorts risks by rule name and locations within a risk by all of their attributes. This makes the output have a stable ordering.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@didroe didroe force-pushed the fix/stable-order-for-risk-locations branch from 80e97e0 to 182b7d0 Compare December 6, 2022 15:55
cfabianski
cfabianski approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@cfabianski cfabianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@cfabianski cfabianski merged commit e47be22 into main Dec 6, 2022
@cfabianski cfabianski deleted the fix/stable-order-for-risk-locations branch December 6, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@didroe @cfabianski