Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Temp file path on Linux is missing separator #271

Merged
merged 1 commit into from
Dec 16, 2022
Merged

fix: Temp file path on Linux is missing separator #271

merged 1 commit into from
Dec 16, 2022

Conversation

spdawson
Copy link
Contributor

@spdawson spdawson commented Dec 16, 2022 •
edited

Description

The malformed temporary file path causes the scan to fail. Sample error message:

filesystem scan error: open /tmpe566c0f8c7ffb00cb50b8bc7fa842e58801f054d-devSHA.jsonl: permission denied

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@spdawson
fix: Temp file path on Linux is missing separator
79e2b3c 
Sample error message:

```
filesystem scan error: open /tmpe566c0f8c7ffb00cb50b8bc7fa842e58801f054d-devSHA.jsonl: permission denied
```
@spdawson spdawson added echoes/effort: XS bug Something isn't working labels Dec 16, 2022
@cfabianski cfabianski merged commit bfc571f into main Dec 16, 2022
@cfabianski cfabianski deleted the fix/temp-file-path-on-Linux branch December 16, 2022 10:25
@cfabianski
Copy link
Collaborator

Could be what was making the CI hang

The error might have been swallowed and the process wasn't exiting properly. @vjerci

@cfabianski cfabianski mentioned this pull request Dec 16, 2022
Closed
2 tasks
@b1pb1p b1pb1p mentioned this pull request Dec 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

@vjerci vjerci Awaiting requested review from vjerci

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spdawson @cfabianski @gotbadger