fix: Only reuse cached detections if the cached run completed #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an invocation is killed or otherwise interrupted, then it should not result in a cached detection set that can be re-used by a subsequent invocation. Closes #335
spdawson
force-pushed
the
335-cached-detections-shouldnt-be-reused-if-the-binary-has-been-killed
branch
from
400fb49
to
f7c3df1
Compare
cfabianski
approved these changes
Jan 9, 2023
spdawson
deleted the
335-cached-detections-shouldnt-be-reused-if-the-binary-has-been-killed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an invocation is killed or otherwise interrupted, then it should not result in a cached detection set that can be re-used by a subsequent invocation.
Related
Closes #335
Checklist