Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(summary): condense rule list and show CWE #647

Merged
merged 4 commits into from Feb 23, 2023

Conversation

gotbadger
Copy link
Contributor

@gotbadger gotbadger commented Feb 22, 2023

Description

Improve overall output from summary report now we have lots of rules

  • Now just display summary of rules run to reduce output

Screenshot 2023-02-22 at 17 24 25

  • Show CWE instead of old DSR

Screenshot 2023-02-22 at 17 24 18

  • update items for summary json output to scope rule info under a rule key
{
      "rule": {
        "cwe_ids": [
          "201"
        ],
        "id": "ruby_third_parties_sentry",
        "description": "Sensitive data sent to Sentry detected.",
        "documentation_url": "https://docs.bearer.com/reference/rules/ruby_third_parties_sentry"
      },
      "line_number": 39,
      "filename": "/Users/phil/development/bearer/bear-publishing/app/controllers/application_controller.rb",
      "category_groups": [
        "PII"
      ],
      "parent_line_number": 39,
      "parent_content": "Sentry.set_user(email: current_user.email)"
    }

Related

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

pkg/report/output/summary/summary.go Outdated Show resolved Hide resolved
pkg/report/output/summary/summary.go Outdated Show resolved Hide resolved
@gotbadger gotbadger marked this pull request as ready for review February 23, 2023 14:09
@gotbadger gotbadger merged commit 7e28dbe into main Feb 23, 2023
@gotbadger gotbadger deleted the feat/improve-report-summary branch February 23, 2023 14:40
@gotbadger gotbadger mentioned this pull request Feb 23, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display CWE in summary instead of DSR
2 participants