Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add internal domains flag #68

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Add internal domains flag #68

merged 2 commits into from
Oct 21, 2022

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Oct 21, 2022

Description

Add internal domains flag and use this during classifier instantiation

We accept internal domains as strings, and then parse these as regular expressions when initializing the interfaces classifier

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.

@swarmia
Copy link

swarmia bot commented Oct 21, 2022

✅  Linked to AMA-3010 · Add option to pass internal / safelist domains to Curio
➡️  Part of AMA-3008 · Support interface classification options
➡️  Part of AMA-2947 · OSS - Curio CLI

@elsapet elsapet force-pushed the AMA-3010-add-option-to-safelist-domains branch from 4283f63 to d72fe22 Compare October 21, 2022 10:20
@elsapet elsapet merged commit 19a2ac1 into main Oct 21, 2022
@elsapet elsapet deleted the AMA-3010-add-option-to-safelist-domains branch October 21, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

@vjerci vjerci Awaiting requested review from vjerci

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elsapet @cfabianski