Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle flow correctly for sanitizer rules #991

Merged
merged 2 commits into from
May 16, 2023

Conversation

didroe
Copy link
Contributor

@didroe didroe commented May 16, 2023

Description

Moves the responsibility for sanitization rules to the evaluator. This allows us to terminate the match properly in the presence of flow/unified nodes.

Previously we wouldn't consider this case sanitized:

x = params[:oops]
y = sanitize(x)

unsafe_call(y)

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@didroe didroe requested a review from cfabianski May 16, 2023 11:53
@didroe didroe force-pushed the fix/handle-flow-with-sanitizers branch from b5e5f39 to c2ed2cb Compare May 16, 2023 12:11
@didroe didroe requested review from elsapet and removed request for cfabianski May 16, 2023 12:40
Copy link
Contributor

@elsapet elsapet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙌

For my interest, are there any related bearer-rules changes, or will these come later?

@didroe
Copy link
Contributor Author

didroe commented May 16, 2023

@elsapet Yeah there are rule changes that I'll be making a PR for soon

@didroe didroe merged commit ada7951 into main May 16, 2023
7 checks passed
@didroe didroe deleted the fix/handle-flow-with-sanitizers branch May 16, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants