Closes #2033: Initial bigint.to_ndarray/list
#2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR (closes Bears-R-Us#2033): - Adds intial `to_ndarray/list` functionality for `bigint` pdarrays - Updates `.bigint_to_pdarrays` to handle edge case where pdarray is all zeroes to begin with - Updates existing tests to remove cast to uint arrays before calling `to_list`
stress-tess
requested review from
Ethan-DeBandi99,
joshmarshall1 and
jaketrookman
jaketrookman
reviewed
Jan 6, 2023
Ethan-DeBandi99
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (closes #2033):
to_ndarray/listfunctionality forbigintpdarrays.bigint_to_uint_arraysto handle edge case where pdarray is all zeroes to begin withto_list