Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chord Names #12

Closed
wants to merge 1 commit into from
Closed

Chord Names #12

wants to merge 1 commit into from

Conversation

Ged2323
Copy link

@Ged2323 Ged2323 commented Dec 19, 2021

Usually Major is written with the capital . It just look aesthetically better when there are chords like mmaj7 will be mMaj7.

Usually Major is written with the capital .  It just look aesthetically better when there are chords like mmaj7 will be mMaj7.
@BeauNouvelle
Copy link
Owner

Sorry for the delay in this, will check it out!

@BeauNouvelle
Copy link
Owner

BeauNouvelle commented Jan 16, 2022

Okay so originally I did want to use capitals, however the app is using this enum to search the chord database, and they are all lowercased.

Another option, which I think may be better than the proposed solution here is a string replace:

  1. Replace all strings in the enum AND the chord database. (fixed before compile)
  2. Replace all occurrences of "maj" with "Maj" in a string before displaying to user. (runtime fix)
  3. Add displayName property to the enum. Perform the second option here, or just switch on every case and return the capitalized text (or anything else you want)

I like option 3 because that could also give us the ability to return ♭ , ♯, ², °, etc symbols.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants