Merge a67c68e into 32fa806

Becklyn · Nov 25, 2019 · c260a1d · c260a1d
2 parents 32fa806 + a67c68e
commit c260a1d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+2.1.2
+=====
+
+*   single and double quotes can won't be encoded anymore in content meaning content can now be a json string in `HTMLElement`s.
+
 2.1.1
 =====
 

diff --git a/composer.json b/composer.json
@@ -14,7 +14,8 @@
         "php": "^7.2"
     },
     "require-dev": {
-        "becklyn/php-cs": "^2.0.2"
+        "becklyn/php-cs": "^2.0.2",
+        "symfony/phpunit-bridge": "^4.3.8"
     },
     "config": {
         "sort-packages": true

diff --git a/src/Builder/HtmlBuilder.php b/src/Builder/HtmlBuilder.php
@@ -36,7 +36,7 @@ public function buildElement (HtmlElement $element) : string
             }
             else
             {
-                $content[] = \htmlspecialchars($entry);
+                $content[] = \htmlspecialchars($entry, \ENT_NOQUOTES);
             }
         }
 

diff --git a/tests/Builder/HtmlBuilderTest.php b/tests/Builder/HtmlBuilderTest.php
@@ -53,6 +53,10 @@ public function provideElements ()
                 new HtmlElement("p", [], ["a ", new SafeMarkup("This is <b>bold</b>!"), " c"]),
                 '<p>a This is <b>bold</b>! c</p>',
             ],
+            [
+                new HtmlElement("script", ["type" =>"application/json"], ['{"foo": "bar"}']),
+                '<script type="application/json">{"foo": "bar"}</script>',
+            ],
         ];
     }