Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove logger for SI in mdpow.fep #276

Merged
merged 1 commit into from
Sep 5, 2023
Merged

remove logger for SI in mdpow.fep #276

merged 1 commit into from
Sep 5, 2023

Conversation

VOD555
Copy link
Contributor

@VOD555 VOD555 commented Sep 5, 2023

Fix #275 Remove the wrong and duplicated logger for SI in mdpow.fep.

@VOD555 VOD555 requested a review from orbeckst September 5, 2023 04:25
@VOD555 VOD555 self-assigned this Sep 5, 2023
@VOD555 VOD555 added the bug label Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #276 (d2307a0) into develop (6449879) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #276      +/-   ##
===========================================
- Coverage    81.29%   81.26%   -0.03%     
===========================================
  Files           15       15              
  Lines         1978     1975       -3     
  Branches       297      297              
===========================================
- Hits          1608     1605       -3     
  Misses         278      278              
  Partials        92       92              
Files Changed Coverage Δ
mdpow/fep.py 68.60% <ø> (-0.18%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@orbeckst orbeckst merged commit f98424b into develop Sep 5, 2023
11 of 14 checks passed
@orbeckst orbeckst deleted the fix_SI_logger branch September 5, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logger in mdpow prints out correlation time (g/2) as the statistical inefficiency (g)
2 participants