This repository has been archived by the owner on Oct 6, 2021. It is now read-only.
Add a retry feature for synchronous requests #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabdsp
force-pushed
the
feature/retry-sync-requests
branch
from
f1992fd
to
8e0c453
Compare
|
Can you report option in the Configuration reference in README ? |
|
Done ;-) |
fabdsp
force-pushed
the
feature/retry-sync-requests
branch
from
64a89e0
to
9320080
Compare
| // Reset the current session to retry the command | ||
| $this->resetSession(); | ||
| $retry--; | ||
| } else { |
There was a problem hiding this comment.
Je suis un peu un puriste du pas de else. Donc tu pourrais modifier comme cela
if($retry > 0) {
$this->resetSession();
$retry--;
continue;
}
throw $e;There was a problem hiding this comment.
J'ai justement essayé de ne pas faire de break / continue dans cette boucle (sinon j'aurais fait un while(true) ... break; continue... ;-))
Il y a d'autres puristes dans le coin qui vont dire qu'ils n'aiment pas les break et les continues ;-)
En plus on peut vouloir ajouter des choses du code après le catch ?
|
👍 |
|
👍 Squash commits then I merge it |
fabdsp
force-pushed
the
feature/retry-sync-requests
branch
from
9320080
to
9b1fe65
Compare
|
Squashed ;-) |
mojoLyon
added a commit
that referenced
this pull request
Jun 3, 2015
Add a retry feature for synchronous requests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add a retry feature for the synchronous requests.
I have no idea how to add a retry for asynchronous requests.